diff --git a/cmd/go-mtg-vk/main.go b/cmd/go-mtg-vk/main.go index 7a46209..a68a113 100644 --- a/cmd/go-mtg-vk/main.go +++ b/cmd/go-mtg-vk/main.go @@ -28,7 +28,7 @@ func main() { GroupId: groupId, ConfirmationString: os.Getenv("VK_CONFIRMATION_STRING"), DictPath: "./assets/additional_cards.json", - Cache: caching.GetClient(), + Cache: caching.NewClient("redis:6379", "", time.Hour*24, 0), InfoFetcher: &cardsinfo.Fetcher{}, } diff --git a/internal/caching/cache_test.go b/internal/caching/cache_test.go index 35a9b57..d434102 100644 --- a/internal/caching/cache_test.go +++ b/internal/caching/cache_test.go @@ -11,11 +11,11 @@ import ( ) func TestGetClient(t *testing.T) { - c := GetClient() - assert.Equal(t, CacheExpiration, c.Expiration) - assert.Equal(t, 0, c.Storage.Options().DB) - assert.Equal(t, HostName, c.Storage.Options().Addr) - assert.Equal(t, Password, c.Storage.Options().Password) + c := NewClient("addr", "123", time.Hour, 1) + assert.Equal(t, time.Hour, c.Expiration) + assert.Equal(t, 1, c.Storage.Options().DB) + assert.Equal(t, "addr", c.Storage.Options().Addr) + assert.Equal(t, "123", c.Storage.Options().Password) } func TestGetSet(t *testing.T) { diff --git a/internal/caching/client.go b/internal/caching/client.go index f767f22..d701d9a 100644 --- a/internal/caching/client.go +++ b/internal/caching/client.go @@ -10,19 +10,15 @@ type CacheClient struct { Expiration time.Duration } -func GetClient() *CacheClient { - client := new(CacheClient) - client.Init() - return client -} - -func (client *CacheClient) Init() { - client.Storage = redis.NewClient(&redis.Options{ - Addr: HostName, - Password: Password, - DB: 0, - }) - client.Expiration = CacheExpiration +func NewClient(addr string, passwd string, expiration time.Duration, db int) *CacheClient { + return &CacheClient{ + Storage: redis.NewClient(&redis.Options{ + Addr: addr, + Password: passwd, + DB: db, + }), + Expiration: expiration, + } } func (client *CacheClient) Set(key string, value string) { diff --git a/internal/caching/secrets.go b/internal/caching/secrets.go deleted file mode 100644 index dddc653..0000000 --- a/internal/caching/secrets.go +++ /dev/null @@ -1,9 +0,0 @@ -package caching - -import ( - "time" -) - -const HostName = "redis:6379" -const Password = "" -const CacheExpiration = time.Hour * 24